Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix cut passages from README in documentation index file #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhlegarreta
Copy link
Collaborator

Fix cut passages from README in documentation index file: remove the start-line and end-line directives and include the README file entirely.

The start-line and end-line directives were making such that relevant passages of the README file providing context for the tool were not being included. Thus the text shown in the documentation index file had some missing parts, and was not making sense.

Do not include the eddymotion-flowchart.svg figure: it is already contained in the README file.

Fix cut passages from `README` in documentation index file: remove the
`start-line` and `end-line` directives and include the `README` file
entirely.

The `start-line` and `end-line` directives were making such that
relevant passages of the `README` file providing context for the
tool were not being included. Thus the text shown in the documentation
index file had some missing parts, and was not making sense.

Do not include the `eddymotion-flowchart.svg` figure: it is already
contained in the `README` file.
@jhlegarreta
Copy link
Collaborator Author

jhlegarreta commented Nov 27, 2024

@effigies tagging you here, as I've seen this commit:
f312b43#diff-8d068e8797e88947c320f79e856c3e16a72b730124a8f9d7031e2c4680dfa534

I see that it was intended to avoid showing the picture in the README and locate it through a relative path in the index.rst file. The current version does show both pictures, and Sphinx does not seem to complain:
https://github.com/nipreps/eddymotion/actions/runs/12032435652/job/33544268816

Are you OK including the entire README as-is?

Edit: This is what the current documentation index looks like and what this patch set intends to fix:

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (f10fc12) to head (82ba295).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          19       19           
  Lines         942      942           
  Branches      119      119           
=======================================
  Hits          624      624           
  Misses        274      274           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant