-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RF: Upgrade nitransforms and remove workarounds #3378
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3378 +/- ##
==========================================
+ Coverage 71.70% 72.06% +0.35%
==========================================
Files 57 57
Lines 4259 4231 -28
Branches 640 456 -184
==========================================
- Hits 3054 3049 -5
+ Misses 1090 1067 -23
Partials 115 115 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
I've manually verified that
load_ants_h5()
can be replaced withnitransforms.manip.load()
and that this does the right thing, and that usingnitransforms.apply(xfm, moving, target)
does indeed get me basically the same thing as ANTs.