MNT: Apply Repo-Review suggestion MY101 #1365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MY101: MyPy strict mode Must have `strict` in the mypy config. MyPy is best with strict or nearly strict configuration. If you are happy with the strictness of your settings already, ignore this check or set `strict = false` explicitly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 207 207
Lines 29494 29494
Branches 4978 4978
=======================================
Hits 28122 28122
Misses 932 932
Partials 440 440 ☔ View full report in Codecov by Sentry. |
|
Ouch, that's a lot of errors! Should we address them? |
|
If you've got the time and desire, sure. Tbh, my goal is to make sure checks and suggestions in downstream tools work. I don't have much energy at the moment to fight with mypy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MY101: MyPy strict mode
Must have
strictin the mypy config. MyPy is best with strict or nearly strict configuration. If you are happy with the strictness of your settings already, ignore this check or setstrict = falseexplicitly.