29 make the api mock server #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hitohata
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
@taniguchiiqqq
Thank you for implementation.
I think you need to write commands on the README. And it seems good if you add the 'docker-compose down' command in the scripts.
|
@hitohata |
|
@taniguchiiqqq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overviews of implementation
added docker-compose.yaml and Dockerfile to run the API mock server based on Nishiki-document's OAS
Review points
Ensure that the mock server can start by
npm run mockcommand, and you can get a response when you access http://localhost:8080/users/aaa