Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organizing the features/ directory #81

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Organizing the features/ directory #81

merged 5 commits into from
Dec 12, 2023

Conversation

nick-y-ito
Copy link
Member

Overview

Organized the sub-directories of the src/features/ directory based on the discussion.

Changes

  • Removed the unnecessary feature directories
    • container/
    • user/
  • Added necessary feature directories
    • foods/
    • profile/
    • auth/
  • Pluralize the group/ directory into groups/

@nick-y-ito nick-y-ito linked an issue Dec 11, 2023 that may be closed by this pull request
Organizing the features/ directory #80
Closed
@vercel Vercel
Copy link

vercel bot commented Dec 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nishiki-frontend ❌ Failed (Inspect) Dec 12, 2023 0:56am

@kotaaaa
Copy link
Member

kotaaaa commented Dec 11, 2023

Thank you for your updates.
What is the difference between profile/ and user/?

@nick-y-ito
Copy link
Member Author

@kotaaaa

What is the difference between profile/ and user/?

I don't know what Kanta intended when he created user/.

My intention is to match feature directories with the bottom nav bar.

image

@kanta1207
Copy link
Member

@kotaaaa

What is the difference between profile/ and user/?

I don't know what Kanta intended when he created user/.

My intention is to match feature directories with the bottom nav bar.

image

Sorry guys, creating "/user" route was just my mistake, and it's better to use "/profile" route.

kotaaaa
kotaaaa approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@kotaaaa kotaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late. Approved

@kotaaaa kotaaaa self-requested a review December 12, 2023 00:53
@nick-y-ito nick-y-ito merged commit 44cf318 into develop Dec 12, 2023
3 of 4 checks passed
@nick-y-ito nick-y-ito deleted the feature/80-features-directory-arrangement branch December 12, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotaaaa kotaaaa kotaaaa approved these changes

@kanta1207 kanta1207 Awaiting requested review from kanta1207

Assignees

@nick-y-ito nick-y-ito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organizing the features/ directory
3 participants
@nick-y-ito @kotaaaa @kanta1207