Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL parameters for map location, layer selection #7

Open
tomalrussell opened this issue May 22, 2024 · 4 comments
Open

URL parameters for map location, layer selection #7

tomalrussell opened this issue May 22, 2024 · 4 comments

Comments

@tomalrussell
Copy link
Member

Also nice-to-have to port over:

See nismod/irv-frontend#20

@eatyourgreens
Copy link
Contributor

@eatyourgreens
Copy link
Contributor

A couple more PRs:

Map sidebar state is shareable now, but the URLs are ~5k characters.

@eatyourgreens
Copy link
Contributor

Some work on shortening URLs by removing redundant query parameters (mostly optimising tree state by writing a list of visible asset layer IDs to the URL.)

@eatyourgreens
Copy link
Contributor

I've run into a weird problem where urlSyncEffect works fine in local development, then doesn't work at all in a production build. It can be worked around by adding a Recoil state effect that updates the window history, but that's annoying.

I'm wondering if this is a side effect of the update to React 18. Recoil seems to be abandoned now, so it wouldn't surprise me if it has bugs with the latest React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants