Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): add query params to navigation links #82

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Aug 7, 2024

Add lat, lon, zoom query params to nav links, so that they're preserved when you right click and open in a new tab.

@eatyourgreens eatyourgreens changed the title Fix-map-link-query-params fix(frontend): add query params to navigation links Aug 7, 2024
@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Aug 7, 2024

This loses the map location when you go to the home page, or the About page. Maybe all navigation links should have query params, so that the map location can be shared?

Fixed by syncing navigation links with Recoil state, rather than with location.search.

@eatyourgreens eatyourgreens force-pushed the fix-map-link-query-params branch 2 times, most recently from 031d5cb to 7aded1e Compare August 8, 2024 09:41
Add the current query params to navigation links, when the link is a map page.
@eatyourgreens eatyourgreens marked this pull request as ready for review August 8, 2024 09:49
@eatyourgreens eatyourgreens merged commit 683ccf7 into main Aug 8, 2024
1 check passed
@eatyourgreens eatyourgreens deleted the fix-map-link-query-params branch August 8, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant