Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixd/Controller: Conditionally include devenv option support by default #584

Closed
wants to merge 3 commits into from

Conversation

k3yss
Copy link

@k3yss k3yss commented Aug 17, 2024

This PR adds default support for devenv.sh with the nixd LSP, eliminating the need for manual configuration. This enhancement makes devenv more intuitive and is likely to promote wider adoption of nixd, devenv, and Nix in general. Specifically this PR does the following things:
1: Fetch devenv's option using the devenv-module-options from the flake at https://github.com/cachix/devenv
2: Checks whether the devenv executable is present, if it is not it won't include the worker for options.
3: Loads the LSP in case of devenv executable being present.

Requires: cachix/devenv#1390 to be merged

@k3yss k3yss requested a review from inclyc as a code owner August 17, 2024 11:46
@inclyc inclyc changed the title feat: Conditionally include devenv option support by default nixd/Controller: Conditionally include devenv option support by default Aug 17, 2024
@inclyc inclyc added the enhancement New feature or request label Aug 17, 2024
Copy link
Member

@inclyc inclyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @k3yss, I think it is a good direction to make the whole ecosystem user-friendly.

Also, conflicts should be resolved before merging :)

nixd/lib/Controller/LifeTime.cpp Outdated Show resolved Hide resolved
@k3yss k3yss marked this pull request as draft August 17, 2024 14:30
@k3yss k3yss force-pushed the os/keys/devenv-support branch from 18da092 to 0fc4f17 Compare August 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants