Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format creation method, and update tar_terra_rast() #15

Merged
merged 31 commits into from
Mar 13, 2024

Conversation

brownag
Copy link
Contributor

@brownag brownag commented Mar 13, 2024

RE: #11 (comment)

  • Generalizes the use of filetype and gdal arguments to terra::writeRaster(), creating new user-facing args to tar_terra_rast()
  • create_format_terra_raster() is a method that returns a tar_format() string given some custom parameters; currently unexported
    • could be renamed format_terra_rast() or similar if we want to provide format method in addition to tar_terra_rast()

Currently basing branch this off of @Aariq https://github.com/Aariq/geotargets/tree/rename_funs
@njtierney

Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! Just a couple of small comments - they don't require fixing but was just curious

R/tar-terra-rast.R Show resolved Hide resolved
R/tar-terra-rast.R Show resolved Hide resolved
R/tar-terra-rast.R Show resolved Hide resolved
@njtierney njtierney merged commit 21b77ae into njtierney:master Mar 13, 2024
5 of 6 checks passed
@njtierney
Copy link
Owner

Thanks @brownag and @Aariq for these improvements, looks great! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants