Add geotargets options functions, with defaults for raster GDAL driver and creation options #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njtierney
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks so much for these changes, @brownag ! This is awesome.
Just a couple of suggestions regarding abstracting out some parts into functions - let me know if you would prefer not to do these?
I also think we will want to import rlang - it's already in targets so we aren't adding a dependency, and I think we could benefit from some rlang functions, such as %||%.
|
Also thank you so much for catching that {covr} error - I had just chalked it up to "CI be weird sometimes" and shelved it for later. This is a huge help! |
Closed
- use `%||%` and `arg_match0() `in `tar_terra_rast()`
Closed
Aariq
requested changes
Mar 13, 2024
This was referenced Mar 14, 2024
njtierney
approved these changes
Mar 15, 2024
Aariq
approved these changes
Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new draft functions were added for #16 :
geotargets_option_get()andgeotargets_option_set().I noticed that the code coverage was failing. There seems to be an issue with modifying the function body for
create_format_terra_raster()insidecovr::package_coverage(). This PR fixes that.It appears coverage issue can be resolved by allowing for the default options for GDAL driver (
filetype) and creation options (gdal) to be used in the template function, rather thanNULL. Though I am still curious what is happening inside the evaluation {covr} does that causes this to fail.