Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard code iteration = "list" #85

Merged
merged 11 commits into from
Aug 19, 2024
Merged

Hard code iteration = "list" #85

merged 11 commits into from
Aug 19, 2024

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Jul 22, 2024

Closes #81 by hard-coding iteration = "list" for all tar_ functions.

Feedback requested:

  • Where to set iteration = "list"---in the defaults for tar_stars(), the call to tar_stars_raw(), the defaults for tar_stars_raw(), or in the call to targets::tar_target_raw()?
  • Should I add a note somewhere in documentation explaining why iteration has to be "list"?

Copy link
Owner

@njtierney njtierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@njtierney
Copy link
Owner

RE:

Feedback requested:

  • Where to set iteration = "list"---in the defaults for tar_stars(), the call to tar_stars_raw(), the defaults for tar_stars_raw(), or in the call to targets::tar_target_raw()?

So I think it would make sense to have this hard coded as the default - so put it inside of tar_stars_raw().

  • Should I add a note somewhere in documentation explaining why iteration has to be "list"?

This would be great - either as a #' @note or #' @description. We can also log this as an issue to revisit down the track?

@Aariq Aariq merged commit ea1f9fe into master Aug 19, 2024
7 checks passed
@Aariq Aariq deleted the iteration-list branch August 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

only allow iteration = "list" for terra targets
2 participants