Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a WIP repostatus badge to readme and fixes R-CMD-check action #9

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Mar 8, 2024

Closes #8

Aariq and others added 3 commits March 7, 2024 17:32
* Update LICENSE using use_mit_licens()
* Fix malformed DESCRIPTION - using changes from https://github.com/njtierney/geotargets/pull/7/files
* add "packages" to utils::globalVariables to avoid CRAN NOTE
* remove importing rlang, glue, and lifecycle - not needed currently (but will doon)
* use `targets::tar_option_get` not `tar_option`
* provide targetsnamespace a missing `tar_option_get` --> `targets::tar_option_get`
* remove `utils` from Imports in DESCRIPTION, even though we import it, R CMD Check complained about this. Strange!
@njtierney njtierney merged commit 33a6ca3 into njtierney:master Mar 11, 2024
6 checks passed
@njtierney
Copy link
Owner

Thanks so much for this, @Aariq ! :)

@Aariq Aariq deleted the readme-eric branch March 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use standard github action for check?
2 participants