Add tar_terra_sds()
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
njtierney
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
This looks good to me! I think down the track these could be wrapped into a central function as you suggested - I think that is a good idea, but I wonder if we can have the best of both worlds where we can still have the convenience functions of tar_terr_sds() and tar_terra_sprc(), but these are powered under the hood by a larger function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was pointed out in #59, the inner workings for
tar_terra_sds()andtar_terra_sprc()are 99% the same. This PR re-factorstar_terra_sprc()to create a stand-alone format function and corresponding standalone raw target function that work for either sds or sprc.I'm considering combining
tar_terra_sprc()andtar_terra_sds()into something liketar_terra_collection(name, command, type = c("sprc", "sds"))but I figured I'd submit the PR as is first to see what you think.