Adds GDAL min version requirement for writing .shz #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aariq I can make these changes to the tests if you like? |
Sure, if you've got an idea of how to mock different GDAL versions, go for it! |
…rsion of GDAL. * check_gdal_version() * check_gdal_shz() * with_local_mock() functions as well
|
I think this should work! I got a bunch of failing tests locally but I'm curious to see how this goes on CI here. Happy for you to merge if you like it :) |
Aariq
commented
Oct 11, 2024
Aariq
commented
Oct 11, 2024
Aariq
commented
Oct 11, 2024
|
Ended up going with a simpler wrapper that does less, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71 by adding a check for GDAL 3.1 or greater. Not sure if there is a way to write a test for this