Update FindTestPlan to actually check the right things

[MrHinsh]

Thank you for responding so quickly.

I still believe the behavior is incorrect.

This line finds the target test Plan and sets it to the variable of testPlan

ITestPlan testPlan = (from p in tmc.Project.TestPlans.Query("Select * From TestPlan") where p.Name == name select p).SingleOrDefault();

This line uses the ID of the target work item to find an item in source, thereby returning the wrong work item.

 var sourceWI = Engine.Source.WorkItems.GetWorkItem(testPlan.Id.ToString());

Observe how in my case the id of 12422 finds a Test Plan in the target, but a Bug work item in the source

Originally posted by @sonofhammer in #1770 (comment)

The fix is to pass in the sourceWorkItemId and use both the Source and Target work items to get the expected and actual RefectedWorkItemID:

   private ITestPlan FindTestPlan(string planName, int sourcePlanId)
   {
       Log.LogDebug("TestPlansAndSuitesMigrationContext::FindTestPlan");
       ITestPlan testPlan = (from p in _targetTestStore.Project.TestPlans.Query("Select * From TestPlan") where p.Name == planName select p).SingleOrDefault();
 
       if (testPlan != null)
       {
           Log.LogDebug("TestPlansAndSuitesMigrationContext::FindTestPlan:: FOUND Test Plan with {name}", planName);
           //Check test plan is in fact the right one
           var sourceWI = Engine.Source.WorkItems.GetWorkItem(sourcePlanId);
           string expectedReflectedId = Engine.Source.WorkItems.CreateReflectedWorkItemId(sourceWI).ToString();
           var targetWI = Engine.Source.WorkItems.GetWorkItem(testPlan.Id.ToString());
           string workItemReflectedId = (string)targetWI.Fields[Engine.Target.Config.AsTeamProjectConfig().ReflectedWorkItemIDFieldName].Value;
           if (workItemReflectedId != expectedReflectedId)
           {
               Log.LogDebug("TestPlansAndSuitesMigrationContext::FindTestPlan:: Found test plan with name {name} does not match {workItemReflectedId} ", planName, workItemReflectedId);
               testPlan = null;
           }
       }
       else
       {
           Log.LogDebug("TestPlansAndSuitesMigrationContext::FindTestPlan:: NOT FOUND Test Plan with {name}", planName);
       }
       return testPlan;
   }

[MrHinsh]

Can you check this @sonofhammer

[MrHinsh]

You have been very helpful here @sonofhammer

[sonofhammer]

Happy to help. My help is but a drop compared to how helpful this tool has been for me on my job. :)