Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine ConsoleFull with ConsoleCore #2372

Closed
wants to merge 3 commits into from
Closed

Conversation

MrHinsh
Copy link
Member

@MrHinsh MrHinsh commented Sep 17, 2024

Have a single MigrationTools.Cli that outputs both net8.0 and net472..

At the moment we can only ship net472 versions....

📝 (MigrationTools.xml): update XML documentation with new commit details
♻️ (ServiceCollectionExtensions): refactor endpoint configuration to prevent multiple registrations

Adding `appsettings.json` to the solution items ensures it is tracked and managed within the solution, improving configuration management. The XML documentation is updated to reflect the latest commit details, ensuring accurate reference information. The refactoring in `ServiceCollectionExtensions` prevents multiple registrations of endpoints by introducing a check to see if they have already been configured, enhancing the efficiency and reliability of the service registration process.
…mit details

⬆️ (MigrationTools.ConsoleFull): add support for .NET 8.0 and update package references
💡 (EndpointRegistrationExtensions): fix string interpolation in console log

The MigrationTools.xml file is updated to reflect the latest branch, commit, and version details. The MigrationTools.ConsoleFull.csproj file now supports both .NET Framework 4.7.2 and .NET 8.0, allowing for greater flexibility and future-proofing. Additionally, package references are conditionally included based on the target framework to ensure compatibility. The EndpointRegistrationExtensions.cs file is updated to use string interpolation correctly, improving code readability and maintainability.
@nkdagility-actions-bot nkdagility-actions-bot bot added enhancement documentation This is an item for a Documentation enhancement enhancement-modern feature labels Sep 17, 2024
@MrHinsh MrHinsh marked this pull request as draft September 17, 2024 16:45
@MrHinsh MrHinsh closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is an item for a Documentation enhancement enhancement enhancement-modern feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant