Fix deprecated TLSv1 and encodestring usage. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code previously only allowed the use of TLSV1 during ticket and VV file retrival, which is broken on newer servers. TLSV1 and older are deprecated by the industry due to security concerns. Newer versions of OpenSSL as well as various distros like Ubuntu (starting with 20.04) disable TLSV1 support by default. As python3 lacks a specific PROTOCOL name for TLSV1.3 when using SSLContext, This update simply has reverted to using PROTOCOL_TLS by default. (Disables SSLV3 and older, but allows for auto selecting any TLS version.) Signed-off-by: Patrick Hibbs <30446633+phibbs7@users.noreply.github.com>
Python 3 deprecates encodestring and will throw warnings in the console if used. Fix the code to use encodebytes instead. (Also uses UTF-8 for de/encode.) Signed-off-by: Patrick Hibbs <30446633+phibbs7@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes #3 (TLSv1 is disabled by default on newer distros. The patch allows the host to choose the TLS version.)
The second patch fixes #4 (Replaces the deprecated encodestring in python 3 with encodebytes.)