-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add reusable dashboard header; implement profile page design #757 #758
chore: add reusable dashboard header; implement profile page design #757 #758
Conversation
* chore: fix tests; create login endpoint nkowaokwu#704 * chore: fix authorization bugs nkowaokwu#704 * chore: update auth tests nkowaokwu#704 * chore: clean up nkowaokwu#704
* chore: define login business logic nkowaokwu#715 * chore: update login test nkowaokwu#715 * chore: update login controller nkowaokwu#715 * Update __tests__/auth.test.js Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update __tests__/auth.test.js Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * chore: sync fixes nkowaokwu#750 * Update src/shared/constants/Developers.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/siteConstants.js Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * chore: convert siteConstants to typescript * chore: update dotenv * chore: update environment variables * chore: update environment variables * Update @types/environment.d.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> --------- Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com>
…aokwu#752) * chore: create logout developer endpoint; add test nkowaokwu#751 * chore: add logout business logic nkowaokwu#751 * Update src/middleware/authenticated.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/middleware/authenticated.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/middleware/authenticated.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/routers/router.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * chore: sync updates nkowaokwu#751 --------- Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com>
* chore: add dashboard design nkowaokwu#753 * chore: sync updates nkowaokwu#753 * chore: add translations nkowaokwu#753
a813206
to
3154fcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great start! make sure that you write Jest tests for the following components:
- DashboardHeader.tsx
- SidebarContext.tsx
- SidebarItem.tsx
- UserInfo.tsx
- dashboard.tsx
- profile.tsx
import React from 'react'; | ||
import { Box, Text, useBreakpointValue } from '@chakra-ui/react'; | ||
|
||
const UserInfo: React.FC = function UserInfo() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of hardcoding these values, it's probably expected that this UserInfo
component will take these values (i.e. name, email, date joined) in as props
update this component so that these values are props instead of hardcoded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. However, I'll need to integrate the auth endpoint to do this. Still on designs now, I'll update ASAP.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
19fa4e0
to
2e4624e
Compare
806d6a6
to
56a0531
Compare
Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com>
Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com>
* chore: fix tests; create login endpoint nkowaokwu#704 * chore: fix authorization bugs nkowaokwu#704 * chore: update auth tests nkowaokwu#704 * chore: clean up nkowaokwu#704
* chore: define login business logic nkowaokwu#715 * chore: update login test nkowaokwu#715 * chore: update login controller nkowaokwu#715 * Update __tests__/auth.test.js Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update __tests__/auth.test.js Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * chore: sync fixes nkowaokwu#750 * Update src/shared/constants/Developers.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/controllers/auth/login.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/siteConstants.js Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * chore: convert siteConstants to typescript * chore: update dotenv * chore: update environment variables * chore: update environment variables * Update @types/environment.d.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> --------- Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com>
…aokwu#752) * chore: create logout developer endpoint; add test nkowaokwu#751 * chore: add logout business logic nkowaokwu#751 * Update src/middleware/authenticated.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/middleware/authenticated.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/middleware/authenticated.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * Update src/routers/router.ts Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com> * chore: sync updates nkowaokwu#751 --------- Co-authored-by: Ijemma Onwuzulike <ijemmaonwuzulike10@gmail.com>
56a0531
to
da7ca47
Compare
79a6a6f
to
6f54cf7
Compare
46a8879
to
d150c27
Compare
fb6ed0f
to
1f29c6c
Compare
c9ef97f
to
8d08544
Compare
You need it in Igbo Language? |
Closing this PR in favor of #786 but thank you for your contributions! These same commits are included in the aforementioned PR. |
Describe your changes
Implemented the Developer profile page design
Design: https://www.figma.com/file/KEdhBREtlZKSXVMw95lZTg/Igbo-API-Editor-Platform?type=design&node-id=2001-1427&mode=design&t=bN9MwqgO5aHLtOC2-0
Issue ticket number and link
#757
Screenshots (if appropriate):