Merge pull request #458 from nla/dependabot/bundler/rubocop-rspec-3.0.1

build(deps-dev): bump rubocop-rspec from 2.25.0 to 3.0.1

Gemfile

@@ -101,6 +101,9 @@ group :development, :test do
   gem "rubocop-rails", require: false
   gem "rubocop-rspec", require: false
   gem "rubocop-performance", require: false
+  gem "rubocop-capybara", require: false
+  gem "rubocop-factory_bot", require: false
+
   gem "solr_wrapper", ">= 0.3"
 
   gem "rspec-rails", "~> 6.1"

Gemfile.lock

@@ -461,10 +461,10 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.31.3)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.19.0)
+    rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.24.0)
-      rubocop (~> 1.33)
+    rubocop-factory_bot (2.26.1)
+      rubocop (~> 1.61)
     rubocop-performance (1.21.1)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
@@ -473,10 +473,8 @@ GEM
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rspec (2.25.0)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
+    rubocop-rspec (3.0.1)
+      rubocop (~> 1.61)
     ruby-next-core (1.0.3)
     ruby-progressbar (1.13.0)
     ruby-statistics (3.0.2)
@@ -649,6 +647,8 @@ DEPENDENCIES
   redis (~> 5.1)
   rsolr (>= 1.0, < 3)
   rspec-rails (~> 6.1)
+  rubocop-capybara
+  rubocop-factory_bot
   rubocop-performance
   rubocop-rails
   rubocop-rspec

spec/components/arclight/breadcrumbs_hierarchy_component_spec.rb

@@ -22,7 +22,7 @@
 
       expect(page).to have_css "li", text: "National Library of Australia"
       expect(page).to have_css "li", text: "Guide to the ABC123"
-      expect(page).not_to have_link "Guide to the ABC123"
+      expect(page).to have_no_link "Guide to the ABC123"
     end
   end
 
@@ -47,11 +47,11 @@
       expect(page).to have_link "Guide to the ABC123", href: "/finding-aids/catalog/abc123"
 
       expect(page).to have_link "DEF", href: "/finding-aids/catalog/abc123abc123_def"
-      expect(page).not_to have_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def"
+      expect(page).to have_no_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def"
 
       expect(page).to have_css "li", text: "GHI"
-      expect(page).not_to have_link "GHI"
-      expect(page).not_to have_link "Guide to the GHI"
+      expect(page).to have_no_link "GHI"
+      expect(page).to have_no_link "Guide to the GHI"
     end
   end
 
@@ -76,14 +76,14 @@
       expect(page).to have_link "Guide to the ABC123", href: "/finding-aids/catalog/abc123"
 
       expect(page).to have_link "DEF", href: "/finding-aids/catalog/abc123abc123_def"
-      expect(page).not_to have_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def"
+      expect(page).to have_no_link "Guide to the DEF", href: "/finding-aids/catalog/abc123abc123_def"
 
       expect(page).to have_link "GHI", href: "/finding-aids/catalog/abc123abc123_ghi"
-      expect(page).not_to have_link "Guide to the GHI", href: "/finding-aids/catalog/abc123abc123_ghi"
+      expect(page).to have_no_link "Guide to the GHI", href: "/finding-aids/catalog/abc123abc123_ghi"
 
       expect(page).to have_css "li", text: "JKL"
-      expect(page).not_to have_link "Guide to the JKL"
-      expect(page).not_to have_link "JKL"
+      expect(page).to have_no_link "Guide to the JKL"
+      expect(page).to have_no_link "JKL"
     end
   end
 end

spec/system/nav_actions_spec.rb

@@ -8,7 +8,7 @@
   it "does not show the History link" do
     visit root_path
 
-    expect(page).not_to have_text("History")
+    expect(page).to have_no_text("History")
   end
 
   context "when FOLIO_UPDATE_IN_PROGRESS is `true`" do
@@ -18,7 +18,7 @@
 
       visit root_path
 
-      expect(page).not_to have_link I18n.t("blacklight.header_links.login"), href: new_user_session_path
+      expect(page).to have_no_link I18n.t("blacklight.header_links.login"), href: new_user_session_path
     end
   end