Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display notes with alternative headings in metadata #446

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

yetti
Copy link
Contributor

@yetti yetti commented Jun 10, 2024

No description provided.

Copy link

Simplecov Report

Covered Threshold
100% 80%

notes.select { |note| JSON.parse(note)["head"].parameterize == I18n.t("ead_notes.#{header}").parameterize }
.map { |note| JSON.parse(note)["p"] }
.flatten
.map { |para| "<p>#{para}</p>".html_safe }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping this in <p/> is ugly, I'm looking for a nicer way to do this, but this will do for now.

@yetti yetti merged commit e4cfc66 into main Jun 10, 2024
2 checks passed
@yetti yetti deleted the feat/blac-695_notes branch June 10, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants