BLAC-675: show item availability status #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yetti
reviewed
Jun 17, 2024
| before do | ||
| cat_response = IO.read("spec/files/catalogue_services/08aed703-3648-54d0-80ef-fddb3c635731.json") | ||
| WebMock.stub_request(:get, /catservices.test\/catalogue-services\/folio\/instance\/08aed703-3648-54d0-80ef-fddb3c635731/) | ||
| .to_return(status: 200, body: cat_response, headers: {"Content-Type" => "application/json"}) |
There was a problem hiding this comment.
@CEdwardsBlasikiewicz the reason why you weren't getting a proper response back was because you weren't specifying a Content-Type header. Faraday will only parse responses with "application/json" headers into JSON automatically.
yetti
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
@CEdwardsBlasikiewicz Sorry, I reviewed this late. Didn't see a notification from GitHub.
Simplecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.