feat: render chronlist, bibref and tables in notes #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplecov Report
|
scott-yeadon
approved these changes
Jun 19, 2024
Heaps. I'm sure there's a completely random edge case that I haven't though about or found that will show up in prod one day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renders encoded
chronlist,bibrefandtableelements inside notes as HTML in Arclight. Currently this only applies to "Bibliographic Note", "Container List" and "Box List". It looks for these elements in the "Text" subnote.It also addresses a bug in Trove FA, where the
chronlistwill display twice due to there being achronlistin the "Text" subnote and "Chronology" subnote of the "Bibliographic Note" with the same data.