Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctpl 252 update global message url #580

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

CEdwardsBlasikiewicz
Copy link
Contributor

To merge afternoon of Tues Dec 10.

Copy link
Member

@JonathanShaw JonathanShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this now right? Prod will update with an environment variable change and the page should be resolving internally for dev/test already

@CEdwardsBlasikiewicz
Copy link
Contributor Author

CEdwardsBlasikiewicz commented Dec 3, 2024

The alert box used to display the message does not show up using the new url since catalogue cannot get the message as the contents of the new link are behind a login.

@CEdwardsBlasikiewicz CEdwardsBlasikiewicz merged commit 7c4f796 into main Dec 11, 2024
0 of 2 checks passed
@CEdwardsBlasikiewicz CEdwardsBlasikiewicz deleted the ctpl-252-update-global-message-url branch December 11, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants