Skip to content

Commit

Permalink
Merge pull request #754 from nla/feat/blac-567-request-summary-link
Browse files Browse the repository at this point in the history
feat: add link to request summary on success page
  • Loading branch information
yetti authored Oct 3, 2023
2 parents 13ee2d3 + 85318d2 commit 5206237
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/views/request/success.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<h2 class="h3 mt-4"><%= @document.first("title_tsim") %></h2>

<div class="row">
<p class="col-12 col-lg-8"><%= t("requesting.success.message") %></p>
<p class="col-12 col-lg-8"><%= t("requesting.success.message", request_summary_url: account_requests_path).html_safe %></p>
<p class="col-12 col-lg-8"><%= t("requesting.success.collection").html_safe %></p>
<%- if @show_scrr %>
<p class="col-12 col-lg-8"><%= t("requesting.success.scrr").html_safe %></p>
Expand Down
2 changes: 1 addition & 1 deletion config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ en:
message: "Request this item to view in the Library's reading room using your library card."
success:
heading: "Request complete"
message: "Thank you for your request. We will email you when it is being processed or if there are any issues with delivery."
message: "Thank you for your request. We will email you when it is being processed or if there are any issues with delivery. You can also track the status of your requests by visiting your <a href=\"%{request_summary_url}\">Request page</a>."
collection: 'Please check collection <a href="https://www.nla.gov.au/using-library/collection-delivery-service/collection-delivery-times">delivery times</a> and <a href="https://www.nla.gov.au/visit-us/opening-hours">opening hours</a>.'
scrr: 'To prepare for your visit, and find out more about use of and access to our special collections, view our Research Guide on <a href="https://www.nla.gov.au/research-guides/using-the-special-collections-reading-room">Using the Special Collections Reading Room</a>.'
metadata:
Expand Down
1 change: 1 addition & 0 deletions spec/features/requests_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@
)

expect(page).to have_link(I18n.t("requesting.btn_back_to_item"), href: "/catalog/1595553")
expect(page).to have_link("Request page", href: account_requests_path)
end

context "when a catalogue search has been performed" do
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/request_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
follow_redirect!

expect(response).to have_http_status(:success)
expect(response.body).to include(I18n.t("requesting.success.message"))
expect(response.body).to include(I18n.t("requesting.success.message", request_summary_url: account_requests_path))
expect(response.body).to include(I18n.t("requesting.success.collection"))
end

Expand Down

0 comments on commit 5206237

Please sign in to comment.