Skip to content

Commit

Permalink
Update news/cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mattfidler committed Oct 9, 2022
1 parent c689f12 commit ef344f7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 16 deletions.
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# dparser 1.3.1-7

* Fixed one remaining strict typing issue, as requested by CRAN.

# dparser 1.3.1-6

* Updated dparser header to have strict typing, as requested by CRAN.
Expand Down
23 changes: 7 additions & 16 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,23 +1,14 @@
# Comments

* Prof Ripley said:
Matthew,

You submitted too soon, so the incoming check systems did not have
-Wstrict-prototypes turned on yet, and did not catch the remaining

[Packages listed above] import headers from
the one on the left with some 'prototypes' fn () . Compiling using
Found the following significant warnings:
lr.c:27:15: warning: function declaration isn’t a prototype [-Wstrict-prototypes]

-Wstrict-prototypes
Should be in place now, can you please fix the remaining warning too?

in CFLAGS (with gcc or clang < 15: this is implied by -pedantic in clang
15) shows warnings that are starting to show up on the CRAN results
pages, and will be used for CRAN incoming checks.
* Fixed

Some of these seem intended to be a function with no arguments, for
which the prototype is fn (void) . But for others, consistency checks
are being circumvented by not using a full prototype. In packages not
reported here these have shown up several bugs already ....

Please correct (in the packages before the colon) before 2022-11-04.

* This fix corrects this for dparser
* Also added back restriction fix that accidentally was deleted when pulling from upstream.

0 comments on commit ef344f7

Please sign in to comment.