Skip to content

Commit

Permalink
Address cran comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mattfidler committed Sep 19, 2024
1 parent 2a99087 commit 8c894d7
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
4 changes: 2 additions & 2 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.0.1
Date: 2024-09-18 16:34:49 UTC
SHA: 69dbb40b433e502882e8092502391208fc495850
Date: 2024-09-18 17:04:52 UTC
SHA: 2a9908797f2eddda3499df6f904aed5413829eb0
3 changes: 1 addition & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: monolix2rx
Title: 'monolix2rx' Converts 'Monolix' Models to 'rxode2'
Title: Converts 'Monolix' Models to 'rxode2'
Version: 0.0.1
Authors@R:
c(person("Matthew","Fidler", role = c("aut", "cre"), email = "matthew.fidler@gmail.com", comment=c(ORCID="0000-0001-8538-6691")),
Expand All @@ -25,7 +25,6 @@ Description: 'Monolix' is a tool for running mixed effects model using
'lixoftConnectors' is available, 'Monolix' can be used to load its model library
instead manually setting up text files (which only works with old versions of
'Monolix').
command line usage.
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
Expand Down
16 changes: 14 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
- Please do not start the title with the package name.

This adds monolix import to the nlmixr2 ecosystem, and is used in the
next release of babelmixr2.
- Fixed; removed package name from the title since it is redundant

- Please proofread your DESCRIPTION.

- It currently reads: "...to load its model library instead manually setting up text
files (...). command line usage."

- I believe it should be: "...to load its model library instead of
manually setting up text files (...)."

- Fixed.

Please fix and resubmit.

## R CMD check results

Expand Down

0 comments on commit 8c894d7

Please sign in to comment.