Merge pull request #693 from nlmixr2/688-feature-request-either-make-…

…the-error-message-clearer-or-switch-to-a-warning-with-empty-arguments-in-call-to-rxrename Warn for empty arguments to rxRename (and anything using `.quoteCallInfoLines()`
nlmixr2 · Jun 23, 2024 · 98d1a86 · 98d1a86
2 parents d1c62b7 + c805589
commit 98d1a86
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # rxode2 (development version)
 
+## New feaures
+
+- Empty arguments to `rxRename()` give a warning (#688)
+
 # rxode2 2.1.3
 
 ## Bug fixes

diff --git a/R/piping.R b/R/piping.R
@@ -284,7 +284,11 @@
       }
     }
     .quoted <- eval(call("quote", callInfo[[i]]))
-    if (length(.quoted) == 1) {
+    if (missing(.quoted)) {
+      # Capture empty arguments (rxode2#688)
+      warning("empty argument ignored")
+      return(NULL)
+    } else if (length(.quoted) == 1) {
       .bracket[i] <- TRUE
       assign(".bracket", .bracket, envir=.env)
     } else if (identical(.quoted[[1]], quote(`{`)) ||

diff --git a/tests/testthat/test-piping-ini.R b/tests/testthat/test-piping-ini.R
@@ -826,3 +826,23 @@ if (!.Call(`_rxode2_isIntel`)) {
 
   })
 }
+
+test_that("empty arguments to rxRename() give a warning (#688)", {
+  mod1 <- function() {
+    ini({
+      Kin=1
+    })
+    model({
+      eff <- Kin
+    })
+  }
+
+  expect_warning(
+    rxRename(mod1, ),
+    "empty argument ignored"
+  )
+  expect_warning(
+    rxRename(mod1, foo = eff, ),
+    "empty argument ignored"
+  )
+})