Merge pull request #750 from nlmixr2/750-backward-warning

With backward compatibility tests subscript of range warning

src/rxData.cpp

@@ -4897,7 +4897,13 @@ SEXP rxSolve_(const RObject &obj, const List &rxControl,
       rxSolveFreeObj = object;
     }
   }
-
+  if (rxSolveDat->mv.size() == 0) {
+    // sometimes the model variables have not been assigned, but this
+    // needs to be assigned to set the user defined functions
+    // this is shown indirectly in the backward compatible testing
+    // where the subscript wasn't defined;  See #750
+    rxSolveDat->mv = rxModelVars(object);
+  }
   _rxode2_udfEnvSet(rxSolveDat->mv[RxMv_udf]);
   LogicalVector recompileUdf = _rxode2_assignUdf(rxSolveDat->mv[RxMv_udf]);
 

tests/testthat/test-backward.R

@@ -173,7 +173,7 @@ expect_error(rxode2("cp<-cent/vc;d/dt(gutcp)<--ka*gutcp;d/dt(cent)<-(ka*gutcp)-q
       expect_equal(as.numeric(tmp$time[2]), 0.5)
       expect_equal(as.numeric(x$time[2]), 1)
       ## $ access updates object.
-      x$add.sampling(0.5)
+      expect_warning(x$add.sampling(0.5), NA) # from issue #750
       expect_equal(as.numeric(x$time[2]), 0.5)
     })
     x <- solve(mod1, theta, ev, inits)