Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

73 cran #74

Merged
merged 3 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rxode2parse
Title: Parsing and Code Generation Functions for 'rxode2'
Version: 2.0.16.9000
Version: 2.0.17
Authors@R: c(
person("Matthew L.", "Fidler", , "matthew.fidler@gmail.com", role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-8538-6691")),
Expand Down
11 changes: 7 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
# rxode2parse (development version)
# rxode2parse 2.0.17

* Added ability to query R user functions in a rxode2 model (will
force single threaded solve)

* Moved core `rxFunParse` and `rxRmFunParse` here so that C and R user
function clashes can be handled

* Model variables now tracks which compartments have a lag-time defined
* Model variables now tracks which compartments have a lag-time
defined

* For compartment with steady state doses (NONMEM equivalent SS=1,
SS=2), an additional tracking time-point is added at to track the
time when the lagged dose is given. As an upshot, the lagged dose
will start at the steady state concentration shifted by + ii - lag
in `rxode2`
in `rxode2` (currently for ode systems only)

* This release calculates non bio-availability adjusted duration for
all rates instead of trying to figure the rate duration during
Expand All @@ -25,7 +26,9 @@
* Steady state bolus doses with `addl` are treated as non steady state
events (like what is observed in `NONMEM`)

* Timsort was upgraded; drop radix support in rxode2 struct
* Timsort was upgraded; drop radix support in rxode2 structure

* Security fixes were applied as requested by CRAN

# rxode2parse 2.0.16

Expand Down
10 changes: 5 additions & 5 deletions src/etTran.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -313,10 +313,10 @@
warn = warn + std::to_string(warnDvid[i]) + ", ";
}
warn = warn + std::to_string(warnDvid[warnDvid.size()-1]);
Rf_warningcall(R_NilValue, warn.c_str());
Rf_warningcall(R_NilValue, "%s", warn.c_str());

Check warning on line 316 in src/etTran.cpp

View check run for this annotation

Codecov / codecov/patch

src/etTran.cpp#L316

Added line #L316 was not covered by tests
}
if (warnConvertDvid.size() > 0){
Rf_warningcall(R_NilValue, warnC.c_str());
Rf_warningcall(R_NilValue, "%s", warnC.c_str());

Check warning on line 319 in src/etTran.cpp

View check run for this annotation

Codecov / codecov/patch

src/etTran.cpp#L319

Added line #L319 was not covered by tests
}
return out;
} else {
Expand Down Expand Up @@ -647,7 +647,7 @@
wKeep += " " + as<std::string>(keep[j]);
}
}
Rf_warningcall(R_NilValue, wKeep.c_str());
Rf_warningcall(R_NilValue, "%s", wKeep.c_str());

Check warning on line 650 in src/etTran.cpp

View check run for this annotation

Codecov / codecov/patch

src/etTran.cpp#L650

Added line #L650 was not covered by tests
}
List covUnits(covCol.size());
CharacterVector covUnitsN(covCol.size());
Expand Down Expand Up @@ -1857,7 +1857,7 @@
doseId.push_back(allId[j]);
}
}
Rf_warningcall(R_NilValue, idWarn.c_str());
Rf_warningcall(R_NilValue, "%s", idWarn.c_str());
redoId=true;
}
}
Expand Down Expand Up @@ -1895,7 +1895,7 @@
}
}
}
if (!_ini0) Rf_warningcall(R_NilValue, idWarn.c_str());
if (!_ini0) Rf_warningcall(R_NilValue, "%s", idWarn.c_str());
}
if (warnCensNA) Rf_warningcall(R_NilValue, _("censoring missing 'DV' values do not make sense"));
if (warnNaTime) Rf_warningcall(R_NilValue, _("missing 'TIME' values do not make sense (ignored)"));
Expand Down
2 changes: 1 addition & 1 deletion src/tran.h
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ static inline int allSpaces(char *v2) {

void parseFree(int last);

#define err_trans(chr) Rf_errorcall(R_NilValue, _(chr));
#define err_trans(chr) Rf_errorcall(R_NilValue, "%s", _(chr));

void _rxode2parse_unprotect(void);

Expand Down
Loading