Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parser.hpp #4037 Improve wording of parse_error exception done #4115

Closed
wants to merge 1 commit into from
Closed

Conversation

chamber909
Copy link

I have corrected the parse_error documentation

@github-actions
Copy link

🔴 Amalgamation check failed! 🔴

The source code has not been amalgamated. @ankush1233
Please read and follow the Contribution Guidelines.

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MR lacks tests, an explanation, and amalgamation.

@gregmarr
Copy link
Contributor

gregmarr commented Sep 5, 2023

FYI, the explanation is in the commit message in the form of an issue link: #4037

@nlohmann nlohmann closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants