Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed casting warnings on linux and macOS #46

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

nmoinvaz
Copy link
Owner

@nmoinvaz nmoinvaz commented Aug 1, 2023

No description provided.

@nmoinvaz nmoinvaz added warnings fix Fixes to compiler warnings cleanup Housekeeping tasks labels Aug 1, 2023
@nmoinvaz nmoinvaz requested a review from sergio-nsk August 1, 2023 17:59
@nmoinvaz nmoinvaz enabled auto-merge (rebase) August 1, 2023 17:59
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #46 (2e7e3fa) into master (521f1e9) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   56.73%   56.73%           
=======================================
  Files          53       53           
  Lines        4600     4600           
  Branches     1060     1060           
=======================================
  Hits         2610     2610           
  Misses       1306     1306           
  Partials      684      684           
Flag Coverage Δ
macos 50.58% <0.00%> (ø)
ubuntu 53.31% <60.00%> (ø)
ubuntu_curl 53.00% <60.00%> (ø)
windows 56.54% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
resolver.c 53.84% <0.00%> (ø)
wpad_dhcp_posix.c 66.40% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergio-nsk sergio-nsk disabled auto-merge August 1, 2023 18:14
wpad_dhcp_posix.c Outdated Show resolved Hide resolved
wpad_dhcp_posix.c Outdated Show resolved Hide resolved
@sergio-nsk
Copy link
Collaborator

Disabled auto-merge if you want to follow the suggestions.

@nmoinvaz nmoinvaz merged commit 27dbeef into master Aug 1, 2023
@nmoinvaz nmoinvaz deleted the nathan/fix-casting-warning branch August 1, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Housekeeping tasks warnings fix Fixes to compiler warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants