Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs with enumerating network adapters on macOS #56

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

nmoinvaz
Copy link
Owner

No description provided.

@nmoinvaz nmoinvaz added the bug Something isn't working label Dec 12, 2023
@nmoinvaz nmoinvaz enabled auto-merge (rebase) December 12, 2023 00:40
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ba5b427) 56.72% compared to head (c1a8af3) 55.68%.

Files Patch % Lines
net_adapter_mac.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   56.72%   55.68%   -1.04%     
==========================================
  Files          53       53              
  Lines        4605     4606       +1     
  Branches     1062     1062              
==========================================
- Hits         2612     2565      -47     
- Misses       1306     1368      +62     
+ Partials      687      673      -14     
Flag Coverage Δ
macos 45.58% <66.66%> (-4.92%) ⬇️
ubuntu 53.41% <ø> (ø)
ubuntu_curl 53.10% <ø> (ø)
windows 56.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz merged commit 8d75d9c into master Dec 12, 2023
14 of 18 checks passed
@nmoinvaz nmoinvaz deleted the nathan/dev/fix-mac-address branch December 12, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants