Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak when failing to get proxies for urls. #61

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

nmoinvaz
Copy link
Owner

No description provided.

@nmoinvaz nmoinvaz added the bug Something isn't working label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6bd9ac0) 57.19% compared to head (b7f1091) 57.19%.

Files Patch % Lines
resolver_posix.c 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   57.19%   57.19%   -0.01%     
==========================================
  Files          53       53              
  Lines        4668     4670       +2     
  Branches     1076     1077       +1     
==========================================
+ Hits         2670     2671       +1     
  Misses       1307     1307              
- Partials      691      692       +1     
Flag Coverage Δ
macos 51.80% <0.00%> (-0.05%) ⬇️
ubuntu 53.70% <75.00%> (-0.01%) ⬇️
ubuntu_curl 53.40% <75.00%> (-0.01%) ⬇️
windows 56.72% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmoinvaz nmoinvaz enabled auto-merge (rebase) January 24, 2024 21:12
@nmoinvaz nmoinvaz merged commit 6bc5050 into master Jan 24, 2024
17 of 18 checks passed
@nmoinvaz nmoinvaz deleted the nathan/master/mem-leak branch January 24, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants