use uint8array in most places

noahm · Apr 16, 2024 · 926b35b · 926b35b
1 parent feb0e7e
commit 926b35b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/sdk/commands/config.ts b/sdk/commands/config.ts
@@ -348,7 +348,7 @@ export class SMXConfig {
   /**
    * Take in the data array and decode it into this.
    */
-  constructor(data: Array<number>, firmwareVersion: number) {
+  constructor(data: Uint8Array, firmwareVersion: number) {
     this.firmwareVersion = firmwareVersion;
     console.log("Config Firmware Version: ", this.firmwareVersion);
     console.log("CONFIG RAW DATA: ", data.toString());
@@ -362,15 +362,15 @@ export class SMXConfig {
     }
   }
 
-  encode(): Array<number> {
+  encode(): Uint8Array {
     if (this.firmwareVersion >= 5) {
-      return Array.from(new Uint8Array(smx_config_t.encode(this.config, true).buffer));
+      return new Uint8Array(smx_config_t.encode(this.config, true).buffer);
     }
 
     if (!this.oldConfig) throw new ReferenceError("Can not encode old config as it is null");
     console.log("Writing Old Config");
     this.convertNewToOld();
-    return Array.from(new Uint8Array(smx_old_config_t.encode(this.oldConfig, true).buffer));
+    return new Uint8Array(smx_old_config_t.encode(this.oldConfig, true).buffer);
   }
 
   /**

diff --git a/sdk/commands/data_info.ts b/sdk/commands/data_info.ts
@@ -22,12 +22,12 @@ export class SMXDeviceInfo {
   firmware_version = 0;
   player = 0;
 
-  constructor(data: Array<number>) {
+  constructor(data: Uint8Array) {
     console.log("DEVICEINFO RAW DATA: ", data.toString());
     this.#decode(data);
   }
 
-  #decode(data: Array<number>) {
+  #decode(data: Uint8Array) {
     const info_packet = data_info_packet_t.decode(data, true);
 
     this.player = Number.parseInt(String.fromCharCode(info_packet.player)) + 1;

diff --git a/sdk/commands/sensor_test.ts b/sdk/commands/sensor_test.ts
@@ -175,7 +175,7 @@ export class SMXPanelTestData {
 export class SMXSensorTestData {
   panels: Array<SMXPanelTestData> = [];
 
-  constructor(data: Array<number>, mode: SensorTestMode, isFsr: boolean) {
+  constructor(data: Uint8Array, mode: SensorTestMode, isFsr: boolean) {
     /**
      * The first 3 bytes are the preamble.
      *

diff --git a/sdk/smx.ts b/sdk/smx.ts
@@ -170,7 +170,7 @@ export class SMXStage {
 
     const command = info.firmware_version < 5 ? API_COMMAND.WRITE_CONFIG : API_COMMAND.WRITE_CONFIG_V5;
     const encoded_config = config.encode();
-    this.events.output$.push([command, encoded_config.length].concat(encoded_config));
+    this.events.output$.push([command, encoded_config.length, ...encoded_config]);
 
     return this.events.ackReports$.firstToPromise();
   }
@@ -235,7 +235,7 @@ export class SMXStage {
 
   private handleConfig(data: Uint8Array): SMXConfig {
     // biome-ignore lint/style/noNonNullAssertion: info should very much be defined here
-    this._config = new SMXConfig(Array.from(data), this.info!.firmware_version);
+    this._config = new SMXConfig(data, this.info!.firmware_version);
 
     // Right now I just want to confirm that decoding and encoding gives us back the same data
     const encoded_config = this._config.encode();
@@ -250,15 +250,15 @@ export class SMXStage {
 
   private handleTestData(data: Uint8Array): SMXSensorTestData {
     // biome-ignore lint/style/noNonNullAssertion: config should very much be defined here
-    this.test = new SMXSensorTestData(Array.from(data), this.test_mode, this.config!.flags.PlatformFlags_FSR);
+    this.test = new SMXSensorTestData(data, this.test_mode, this.config!.flags.PlatformFlags_FSR);
 
     this.debug && console.log("Got Test: ", this.test);
 
     return this.test;
   }
 
   private handleDeviceInfo(data: Uint8Array): SMXDeviceInfo {
-    this.info = new SMXDeviceInfo(Array.from(data));
+    this.info = new SMXDeviceInfo(data);
 
     this.debug && console.log("Got Info: ", this.info);