Fetch missing value again before throwing #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahm
approved these changes
Apr 11, 2024
sdk/smx.ts
Outdated
| setLightStrip(color: RGB): Promise<AckPacket> { | ||
| if (!this.info) throw new ReferenceError("this.info does not exist for stage. Can not set light strip"); | ||
|
|
||
| async setLightStrip(color: RGB): Promise<AckPacket> { |
There was a problem hiding this comment.
technically don't need these async keywords when you never use await in the function body, but doesn't really matter either way
There was a problem hiding this comment.
oh right yeah, those might just be a hold out when I was testing a different method earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a SMXStage function requires
infoorconfig, we try to fetch it again first and if it's still missing then we'll throw an error.