Skip to content

ci: add more golangci-lint rules #365

ci: add more golangci-lint rules

ci: add more golangci-lint rules #365

Triggered via pull request December 9, 2024 22:23
Status Failure
Total duration 56s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors
golangci-lint: internal/gh/gh_test.go#L192
importShadow: shadow of imported from 'github.com/nobe4/gh-not/internal/config' package 'config' (gocritic)
golangci-lint: internal/gh/gh_test.go#L101
importShadow: shadow of imported from 'github.com/nobe4/gh-not/internal/api/mock' package 'mock' (gocritic)
golangci-lint: internal/gh/gh.go#L123
importShadow: shadow of imported from 'github.com/nobe4/gh-not/internal/notifications' package 'notifications' (gocritic)
golangci-lint: internal/gh/gh.go#L41
importShadow: shadow of imported package 'url' (gocritic)
golangci-lint: internal/gh/gh.go#L40
importShadow: shadow of imported from 'github.com/nobe4/gh-not/internal/api' package 'api' (gocritic)
golangci-lint: internal/config/config.go#L76
unnamedResult: consider giving a name to these results (gocritic)
golangci-lint: internal/api/mock/calls.go#L47
sloppyReassign: re-assignment to `err` can be replaced with `err := json.Unmarshal(content, &rawCalls)` (gocritic)
golangci-lint: internal/colors/colors.go#L7
paramTypeCombine: func(c string, s string) string could be replaced with func(c, s string) string (gocritic)
golangci-lint: internal/cache/cache.go#L101
octalLiteral: use new octal literal style, 0o644 (gocritic)
golangci-lint: internal/cache/cache.go#L97
octalLiteral: use new octal literal style, 0o755 (gocritic)