Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable golangci-lint #226

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

ccoVeille
Copy link
Contributor

Currently 43 errors, more rules could be enabled.

But let's start with these ones.

Fixes:

@ccoVeille
Copy link
Contributor Author

if you want to test locally simply launch

golangci-lint run ./...

Some linters are able to apply fix via golangci-lint, if you want to apply fix use this

golangci-lint run -fix ./...

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
Currently 43 errors, more rules could be enabled.

But let's start with these ones.
Copy link
Owner

@nobe4 nobe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks appropriate! Thanks!

I'll merge this with the ❌ and will fix in a subsequent PR.

@nobe4 nobe4 merged commit af16957 into nobe4:main Dec 7, 2024
4 of 5 checks passed
@ccoVeille ccoVeille deleted the golangci-lint branch December 7, 2024 14:01
nobe4 added a commit that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants