fix: enable more linters #234
Conversation
| if err := os.MkdirAll(filepath.Dir(c.path), 0o755); err != nil { | ||
| if err := os.MkdirAll( | ||
| filepath.Dir(c.path), | ||
| syscall.S_IRUSR|syscall.S_IWUSR|syscall.S_IXUSR, |
There was a problem hiding this comment.
What linter suggested you to use this?
I have never met this constants
There was a problem hiding this comment.
It was mnd, for the "magic number" 755 and 6xx in other places.
There was a problem hiding this comment.
There was a problem hiding this comment.
Amazing, this will be very useful!
There was a problem hiding this comment.
I don't know if you saw it, but my linter suggestion went in a dead end
There was a problem hiding this comment.
Yeah, I noticed. I might switch to x/sys, but as long as no linter complains about it I'll leave it 🤣
There was a problem hiding this comment.
I think I add myself a depguard rules about using syscall package to enforce using golang.orgg/x/sys
There was a problem hiding this comment.
When you do, feel free to ping me, I'll make the same change :)
There was a problem hiding this comment.
There was a problem hiding this comment.
fyi, I decided to move back to using numbers with an updated mnd rule: #240
| Read(d any) error | ||
| Write(d any) error | ||
| Refresh(t time.Time) | ||
| RefreshedAt() time.Time | ||
| } | ||
|
|
There was a problem hiding this comment.
Did a linter suggested you to add variable name here? If so, which one?
I'm curious about adding it to my own settings
There was a problem hiding this comment.
I think it was https://github.com/macabu/inamedparam
There was a problem hiding this comment.
Thanks, I will take a look
Using syscall is not recommended and having fixed numbers + the appropriate mnd configuration is enough. cc #234 (comment)
No description provided.