Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check for IBC receiver address #301

Closed

Conversation

yito88
Copy link

@yito88 yito88 commented Feb 2, 2024

When a non-Cosmos address is given as an IBC receiver, the IBC transfer fails due to the address decoding error even if the address is valid on the destination chain.

This PR fixed the check to skip the decoding error of the IBC receiver address because the address could be non-Cosmos and the destination chain should be in charge of minting tokens.

Copy link

height bot commented Feb 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@johnletey
Copy link
Member

Thanks so much for your contribution and report @yito88

I'm closing this in favour of circlefin/noble-fiattokenfactory#20, as that repository is the truth of source for this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants