Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_always_lock_free from std::atomics in function BasicCheck file atomic_helpers.h #34

Open
wants to merge 4 commits into
base: iree-aie
Choose a base branch
from
Open

Use is_always_lock_free from std::atomics in function BasicCheck file atomic_helpers.h #34

wants to merge 4 commits into from

Conversation

dezhiAmd
Copy link
Collaborator

@dezhiAmd dezhiAmd commented Sep 27, 2024 •
edited
Loading

What has been changed:

  1. Remove an input parameter which function BasicCheck never uses
  2. Replace a Linux specific function "__atomic_always_lock_free" with std::atomic constant "is_always_lock_free" added in c++17
  3. Change compiling flags from -std=c++11 to -std=c++17

@dezhiAmd dezhiAmd marked this pull request as draft September 27, 2024 20:52
@dezhiAmd dezhiAmd changed the title Use is_always_lock_free from std::atomics in function BasicCheck file atomic_helpers.h WIP: Use is_always_lock_free from std::atomics in function BasicCheck file atomic_helpers.h Sep 27, 2024
@dezhiAmd dezhiAmd changed the title WIP: Use is_always_lock_free from std::atomics in function BasicCheck file atomic_helpers.h Use is_always_lock_free from std::atomics in function BasicCheck file atomic_helpers.h Sep 27, 2024
@dezhiAmd dezhiAmd marked this pull request as ready for review September 27, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atgutier atgutier Awaiting requested review from atgutier

@makslevental makslevental Awaiting requested review from makslevental

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dezhiAmd @makslevental