(shortfin-sd) Program initialization and logging improvements #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best found throughput number (11/6) is at .89 samples per second per gpu. More progress to come. |
|
New best: Repro: in another shell: |
stellaraccident
approved these changes
Nov 7, 2024
shortfin/dev_me.py
Outdated
| @@ -196,7 +197,8 @@ def configure_mode(env_info: EnvInfo, args): | |||
| env_vars["SHORTFIN_IREE_SOURCE_DIR"] = env_info.iree_dir | |||
| if env_info.clang_exe: | |||
| env_vars["CC"] = env_info.clang_exe | |||
| env_vars["CXX"] = f"{env_info.clang_exe}++" | |||
| clangxx_exe = "clang++-".join(env_info.clang_exe.split("clang-")) | |||
There was a problem hiding this comment.
Does this work for unadorned "clang" commands? Maybe drop this file from the patch and we do it separately?
| @@ -34,7 +34,7 @@ def __init__(self, device="local-task", device_ids=None): | |||
| raise ValueError(f"Device id {did} could not be parsed.") | |||
| else: | |||
| selected = available | |||
| sb = sf.amdgpu.SystemBuilder(amdgpu_visible_devices=";".join(selected)) | |||
| sb = sf.SystemBuilder(system_type="amdgpu") | |||
There was a problem hiding this comment.
You can just create the SystemBuilder once:
sb = sf.SystemBuilder(system_type="amdgpu")
sb.visible_devices = get_selected_devices(sb)
self.ls = sb.create_system()
(i.e. you can set properties between construction of the SystemBuilder and create_system())
Note that the property takes a normal list of strings so no need to join.
It also looks like you dropped the visible_devices thing in this patch.
There was a problem hiding this comment.
yeah, that makes more sense. thanks.
| @@ -23,6 +23,7 @@ AMDGPUSystemBuilder::AMDGPUSystemBuilder(iree_allocator_t host_allocator, | |||
| iree_hal_hip_device_params_initialize(&default_device_params_); | |||
| InitializeDefaultSettings(); | |||
| config_options().ValidateUndef(); | |||
| default_device_params_.async_allocations = false; | |||
monorimet
force-pushed
the
sdxl-multi-program-init
branch
from
307100b
to
01d2691
Compare
monorimet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.