Add metadata to shortfin Python package #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
approved these changes
Nov 13, 2024
Comment on lines
+16
to
+17
| description = "SHARK inference library and serving engine" | ||
| readme = "README.md" |
There was a problem hiding this comment.
Can you also update the README text in this PR to match this description?
(It would be weird for a project on PyPI to have "C++ library" right at the top of the page)
There was a problem hiding this comment.
Good point! Sure, I will add it to this PR prior to merging.
Similar to nod-ai#489, this adds mertadata to the shortfin Python package but does so by extending the `pyproject.toml` file instead of adding metadata to the `setup.py` file.
marbre
force-pushed
the
shortfin-package-metadata
branch
from
354ca53
to
fa16120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #489, this adds mertadata to the shortfin Python package but does so by extending the
pyproject.tomlfile instead of adding metadata to thesetup.pyfile.