-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sglang User Doc #498
Merged
Merged
Sglang User Doc #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight adjustments to the user e2e doc
Remove markdownlint pre-commit step
Remove references to `$PORT` env var, Comment TODO's, so that they only appear in raw view
stbaione
requested review from
ScottTodd,
renxida,
kumardeepakamd and
amd-chrissosa
November 13, 2024 15:52
amd-chrissosa
approved these changes
Nov 13, 2024
ScottTodd
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
docs/shortfin/llm/user/shortfin_with_sglang_frontend_language.md
Outdated
Show resolved
Hide resolved
docs/shortfin/llm/user/shortfin_with_sglang_frontend_language.md
Outdated
Show resolved
Hide resolved
…o sglang-user-doc
Update SGLang docs to use the examples from out integration tests, and the `llama-3-instruct` chat template
Add `Software` and `Hardware` prerequisites
ScottTodd
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation for running SGLang with Shortfin LLM Server.
Currently, only focus on the sglang docs. I created this PR from the same repo as the other shortfin llm server docs. Those diffs should go away once that is merged.
It links to the existing
Shortfin LLM Server User Doc
to setup and run shortfin. It then shows how to install SGLang inside of the same virtual environment.From there it has instructions for running a
Multi-Turn Q&A Flow
,Fork Flow
, and how to run theBenchmark
script against the shortfin server.