[shortfin] Pin pydantic-core to 2.27.0 #595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pins pydantic-core to 2.27.0, as building 2.27.1 fails to build for Python 3.13t.
|
Actually, pydantic-core 2.27.1 cannot be build with free-threaded Python as PyO3 was bumped to 0.22.6 to prevent accidental installs on free-threaded Python, see pydantic/pydantic-core#1550. Therefore, we should re-evaluate the deps in the requirements file: pydantic-core is required by pydantic which is required by fastapi. |
marbre
added a commit
to marbre/shark-ai
that referenced
this pull request
Nov 22, 2024
This removes fastapi as a requirements as it pulls in pydantic which depends on pydantic-core. The latter cannot be build for a free-threaded Python and as part of the 0.27.1 release bumped PyO3 to 0.22.6 to prevent accidental installs on free-threaded Python. Supersedes and closes nod-ai#595.
marbre
added a commit
that referenced
this pull request
Nov 22, 2024
This removes fastapi as a requirements as it pulls in pydantic which depends on pydantic-core. The latter cannot be build for a free-threaded Python and as part of the 0.27.1 release bumped PyO3 to 0.22.6 to prevent accidental installs on free-threaded Python. Supersedes and closes #595.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pins pydantic-core to 2.27.0, as building 2.27.1 fails to build for Python 3.13t.