[tuner]: use iree_gpu.MMAIntrinsic and iree_gpu.MMAAttr #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtianliu
force-pushed
the
mma_format
branch
from
127ed6d
to
3a07b21
Compare
kuhar
requested changes
Nov 25, 2024
kuhar
reviewed
Nov 26, 2024
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
bangtianliu
force-pushed
the
mma_format
branch
from
e5ee7dd
to
385f484
Compare
kuhar
reviewed
Nov 26, 2024
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
kuhar
approved these changes
Nov 26, 2024
13 tasks
Signed-off-by: Bangtian Liu <liubangtian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the data class
MfmaIntrinsicfrom the codebase, and use IREE attributes (iree_gpu.MMAIntrinsicandiree_gpu.MMAAttr) for MFMA intrinsics in the tuner.Motivation for this PR: The original MLIR processing relies heavily on string-based operations, making it fragile and prone to breaking with updates to the IREE Compiler. To address this, we aim to leverage key attributes directly through IREE Python bindings, enabled by exposing these attributes. For more details, refer to this issue.