src: Avoid calling into C++ with a null this #1313
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests all crash the process because
instance
is null when exceptions are off. If ObjectWrap methods try to access anything onthis
, it's bad news. I don't think the method should get called at all in this case since there's a pending JS exception anyways.Context: I recently ported node-canvas to
node-addon-api
and we have tests for this. It was a pain in v8/NAN, and we could remove a lot of code with these changes. I had a positive experience working withnode-addon-api
, great work everyone!