Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Commit

Permalink
build: disable compiler inlining on z/OS (#146)
Browse files Browse the repository at this point in the history
In Node v14 on z/OS, test `test-exception.js` fails due to a
compiler issue with inlining.

This PR works around it by disabling compiler inlining.

I confirmed that, with this change, `npm test` continues to pass in
Node v8.17.0 (which uses D190508 compiler version), as well as in
Node v12.16.1 (which uses D191122 as in v14).

Once the new Wyvern on z compiler is available for use in Node v14,
we'll revisit and undo this change if Woz resolves the issue.

PR-URL: #146
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Co-authored-by: baghdadi <baghdadi@ca.ibm.com>
  • Loading branch information
gabylb and gabylb committed Jul 3, 2020
1 parent 26fec2d commit ae00a73
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"dll_files": [ "dbghelp.dll", "Netapi32.dll", "PsApi.dll", "Ws2_32.dll" ],
}],
["OS=='zos'", {
"cflags!": [ "-O2", "-O3" ],
"cflags": [ "-qascii" ],
"cflags!": [ "-O2", "-O3", "-qINLINE=::150:100000" ],
"cflags": [ "-qascii", "-qnoinline" ],
}],
],
"defines": [
Expand Down

0 comments on commit ae00a73

Please sign in to comment.