Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: no supporting model validation #20

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bigdong89
Copy link

fix bug: not support model validation when using this plugin

@nodkz
Copy link
Owner

nodkz commented Jun 14, 2018

Why do you want use post hook, not pre hook as now is?

Anyway i will not accept your PR with your changes in package.json file. Please explain your changes with your use case (example) and revert changes in package.json.

Thanks.

@bigdong89
Copy link
Author

  1. For my application, I modified package info.
    So you have to change it back. Or someone would make another pull request.
  2. why not "pre('validate')" but "post('validate')"
    2.1 "pre('validate')" make validation funciton fail but "post('validate') can make it work.
    2.2 "pre('validate')" will waste many sequence IDs if validation fails.

@bigdong89
Copy link
Author

I failed to fork it again to make new pull request because github only allows me to fork once.
Can't delete my previous fork either because my own application needs it.

Sorry, there must be other guys who fork it and help me make this merge request.

@bigdong89 bigdong89 changed the title fix bug: not support model validation fix bug: no supporting model validation Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants