Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to noir 0.34.0 #4

Closed
wants to merge 2 commits into from
Closed

Conversation

olehmisar
Copy link
Contributor

@olehmisar olehmisar commented Sep 11, 2024

fixes 0.34.0 breaking changes. Also makes it work with aztec-nargo.

Had to move compute_chunks to a separate function because it fails to compile:

[noir_string_search] Testing test... error: Type annotation needed
    ┌─ src/lib.nr:209:48
    │
209 │         StringBody { body, chunks: StringBody::compute_chunks(body), byte_length: length }
    │                                                -------------- Could not determine type of generic argument
    │
    = Call stack:
      1. src/lib.nr:209:48

if someone needs for aztec-nargo today:

string_search = { tag = "v0.2.0", git = "https://github.com/olehmisar/noir_string_search/" }

@olehmisar
Copy link
Contributor Author

@TomAFrench review please

@saleel
Copy link
Contributor

saleel commented Sep 17, 2024

👍
We can also update the version in Nargo.toml

Copy link

@michaeljklein michaeljklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unused import and Call to unconstrained function is unsafe warnings. Otherwise, LGTM

@TomAFrench
Copy link
Member

Superceded by #5

@TomAFrench TomAFrench closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants