-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile hidapi library from source #94
Merged
norberttak
merged 6 commits into
master
from
90-bug-plugin-crash-with-saitek-radio-panel
Mar 29, 2024
Merged
Compile hidapi library from source #94
norberttak
merged 6 commits into
master
from
90-bug-plugin-crash-with-saitek-radio-panel
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this modification the built plugin doesn't have dependecy for the hidapi library:
|
@MrAnno may I ask you to do a quick review of the CMAKE files? I'm not sure if I modified it in a proper way. |
norberttak
force-pushed
the
90-bug-plugin-crash-with-saitek-radio-panel
branch
9 times, most recently
from
March 24, 2024 06:48
447712d
to
7806ab2
Compare
This was referenced Mar 24, 2024
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
norberttak
force-pushed
the
90-bug-plugin-crash-with-saitek-radio-panel
branch
from
March 24, 2024 20:46
7806ab2
to
debd4b3
Compare
norberttak
changed the title
On Linux systems compile hid.c from source
Compile hidapi library from source
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to compile the enclosed hid.c from source instead of using the system installed hidapi package. As the #90 issue stated, the hid_send_feature_report() doesn't work on Linux systems with the system packages.
With this modification we can use the v0.14 version of hidapi and we won't have the runtme dependency on Linux systems.
On Windows I still kept the original model: use the precompiled .dll