Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile hidapi library from source #94

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

norberttak
Copy link
Owner

@norberttak norberttak commented Mar 21, 2024

The aim of this PR is to compile the enclosed hid.c from source instead of using the system installed hidapi package. As the #90 issue stated, the hid_send_feature_report() doesn't work on Linux systems with the system packages.
With this modification we can use the v0.14 version of hidapi and we won't have the runtme dependency on Linux systems.
On Windows I still kept the original model: use the precompiled .dll

@norberttak norberttak added the bug Something isn't working label Mar 21, 2024
@norberttak norberttak added this to the v1.9 milestone Mar 21, 2024
@norberttak norberttak self-assigned this Mar 21, 2024
@norberttak norberttak linked an issue Mar 21, 2024 that may be closed by this pull request
@norberttak
Copy link
Owner Author

With this modification the built plugin doesn't have dependecy for the hidapi library:

$ ldd /tmp/xpanel-install/XPanel/64/lin.xpl
        linux-vdso.so.1 (0x00007fffb8504000)
        liblua5.4.so.0 => /lib/x86_64-linux-gnu/liblua5.4.so.0 (0x00007fd55c886000)
        libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fd55c65a000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fd55c573000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fd55c553000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd55c32a000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fd55c9e4000)

@norberttak
Copy link
Owner Author

@MrAnno may I ask you to do a quick review of the CMAKE files? I'm not sure if I modified it in a proper way.

@norberttak norberttak force-pushed the 90-bug-plugin-crash-with-saitek-radio-panel branch 9 times, most recently from 447712d to 7806ab2 Compare March 24, 2024 06:48
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
Signed-off-by: Norbert Takacs <norberttak@gmail.com>
@norberttak norberttak force-pushed the 90-bug-plugin-crash-with-saitek-radio-panel branch from 7806ab2 to debd4b3 Compare March 24, 2024 20:46
@norberttak norberttak changed the title On Linux systems compile hid.c from source Compile hidapi library from source Mar 29, 2024
@norberttak norberttak merged commit ddf87ad into master Mar 29, 2024
4 checks passed
@norberttak norberttak deleted the 90-bug-plugin-crash-with-saitek-radio-panel branch April 28, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] hid_send_feature_report error on Gentoo Linux
1 participant